feat: Support AlwaysEjectOneHost configuration in Outlier Detection#8149
feat: Support AlwaysEjectOneHost configuration in Outlier Detection#8149Inode1 wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: i.makarychev <i.makarychev@tbank.ru>
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8149 +/- ##
==========================================
- Coverage 73.69% 73.69% -0.01%
==========================================
Files 240 240
Lines 36500 36503 +3
==========================================
+ Hits 26900 26902 +2
Misses 7696 7696
- Partials 1904 1905 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| // | ||
| // +kubebuilder:default=false | ||
| // +optional | ||
| AlwaysEjectOneHost *bool `json:"alwaysEjectOneHost,omitempty"` |
There was a problem hiding this comment.
can we use Endpoint instead of Host here
There was a problem hiding this comment.
We could, but "Host" matches Envoy's internal terminology and the field directly controls Envoy's always_eject_one_host outlier detection behavior, it cloud confuse users familiar with Envoy's outlier detection documentation
There was a problem hiding this comment.
we use Endpoint instead of Host in Envoy Gateway, since Endpoint maps better to the API nomenclature used in this project (closer to Gateway API)
2 participants
What type of PR is this?
Support AlwaysEjectOneHost configuration in Outlier Detection
Which issue(s) this PR fixes:
Fixes #8140
Release Notes: Yes